Skip to content

Comments

[pull] main from NVIDIA:main#490

Merged
pull[bot] merged 2 commits intophu0ngng:mainfrom
NVIDIA:main
Feb 17, 2026
Merged

[pull] main from NVIDIA:main#490
pull[bot] merged 2 commits intophu0ngng:mainfrom
NVIDIA:main

Conversation

@pull
Copy link

@pull pull bot commented Feb 17, 2026

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.4)

Can you help keep this open source service alive? 💖 Please sponsor : )

hemildesai and others added 2 commits February 17, 2026 08:51
…fail (#2684)

- Include `build_tools/` in the source distribution via `MANIFEST.in` so that cached builds from `uv` (and `pip`) can resolve `setup.py`'s top-level imports

`setup.py` imports from `build_tools` at the top level:

```python
from build_tools.build_ext import CMakeExtension, get_build_ext
from build_tools.te_version import te_version
from build_tools.utils import cuda_archs, cuda_version, ...
```

The `__legacy__` build backend in `pyproject.toml` adds the source root to `sys.path`, so these imports work when building directly from the source tree. However, `build_tools/` is not included in the sdist because:

1. `MANIFEST.in` did not list it
2. `build_tools/` is not discovered by `find_packages()` (it's a standalone directory at the repo root, not under `transformer_engine/`)

When `uv` caches the sdist and later builds a wheel from it, the sdist is extracted to a temporary directory where `build_tools/` is absent, causing a `ModuleNotFoundError`. Passing `--no-cache` to `uv` works around this by forcing a fresh build from the full source tree.

Added `build_tools` to `MANIFEST.in`:

```diff
 recursive-include transformer_engine/common/include *.*
+recursive-include build_tools *.py *.txt
```

- [x] `python setup.py sdist` produces a tarball that contains `build_tools/`

```
$ tar tzf dist/transformer_engine-*.tar.gz | grep build_tools
transformer_engine-2.13.0.dev0+82f7ebeb/build_tools/
transformer_engine-2.13.0.dev0+82f7ebeb/build_tools/VERSION.txt
transformer_engine-2.13.0.dev0+82f7ebeb/build_tools/__init__.py
transformer_engine-2.13.0.dev0+82f7ebeb/build_tools/build_ext.py
transformer_engine-2.13.0.dev0+82f7ebeb/build_tools/jax.py
transformer_engine-2.13.0.dev0+82f7ebeb/build_tools/pytorch.py
transformer_engine-2.13.0.dev0+82f7ebeb/build_tools/te_version.py
transformer_engine-2.13.0.dev0+82f7ebeb/build_tools/utils.py
```

Signed-off-by: Hemil Desai <hemild@nvidia.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
* initial debug of inspect ffi

Signed-off-by: Jeremy Berchtold <jberchtold@nvidia.com>

* writing binary dumps of tensors works

Signed-off-by: Jeremy Berchtold <jberchtold@nvidia.com>

* loading works

Signed-off-by: Jeremy Berchtold <jberchtold@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* refactor

Signed-off-by: Jeremy Berchtold <jberchtold@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Add tensor statistics

Signed-off-by: Jeremy Berchtold <jberchtold@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* lint

Signed-off-by: Jeremy Berchtold <jberchtold@nvidia.com>

* Add cuda error check and tests

Signed-off-by: Jeremy Berchtold <jberchtold@nvidia.com>

* Ad __init__.py to debug folder

Signed-off-by: Jeremy Berchtold <jberchtold@nvidia.com>

* Fix lint

Signed-off-by: Jeremy Berchtold <jberchtold@nvidia.com>

* Fix lint

Signed-off-by: Jeremy Berchtold <jberchtold@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Address greptile comments

Signed-off-by: Jeremy Berchtold <jberchtold@nvidia.com>

* Lint

Signed-off-by: Jeremy Berchtold <jberchtold@nvidia.com>

* Gate tests behind fp8 support

Signed-off-by: Jeremy Berchtold <jberchtold@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Jeremy Berchtold <jberchtold@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@pull pull bot locked and limited conversation to collaborators Feb 17, 2026
@pull pull bot added the ⤵️ pull label Feb 17, 2026
@pull pull bot merged commit 7e48fa1 into phu0ngng:main Feb 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants